Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Document multi-reciprocal has_one relations #417

Merged
merged 1 commit into from
Dec 11, 2023
Merged

DOC Document multi-reciprocal has_one relations #417

merged 1 commit into from
Dec 11, 2023
+107 −0

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Dec 5, 2023
Closed
emteknetnz
emteknetnz requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recommended changing the words in the constant from 'mutli reciprocal' to 'multi relational'. We'd probably want to change all the 'instances of 'reciprocal' in here with 'relational'

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Dec 10, 2023 •
edited
Loading

We'd probably want to change all the 'instances of 'reciprocal' in here with 'relational'

This release includes a new has_one syntax to declare that your has_one should be allowed to handle multiple reciprocal has_many relations.

This wouldn't make sense if it said "handle multiple relational has_many relations" so I'm leaving this one as is

@emteknetnz emteknetnz merged commit fd9af10 into silverstripe:5 Dec 11, 2023
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/multireciprocal-hasone branch December 11, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz